Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override NDArrayType class attributes #1016

Closed
wants to merge 1 commit into from
Closed

override NDArrayType class attributes #1016

wants to merge 1 commit into from

Conversation

CagtayFabry
Copy link
Contributor

set instance attributes of NDArrayType to None when reading from tree as discussed in #1015

@CagtayFabry CagtayFabry marked this pull request as ready for review August 18, 2021 16:28
@CagtayFabry
Copy link
Contributor Author

could you take another look here @eslavich ?

@eslavich
Copy link
Contributor

eslavich commented Dec 2, 2021

I'll look later today, we should get this merged before I release 2.8.2. Thanks for the reminder...

@eslavich eslavich mentioned this pull request Dec 2, 2021
Merged
@eslavich
Copy link
Contributor

eslavich commented Dec 3, 2021

Closing in favor of #1031

@eslavich eslavich closed this Dec 3, 2021
@CagtayFabry CagtayFabry deleted the delete_ndarray_attr branch December 3, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CagtayFabry @eslavich